[alsa-devel] [PATCH 122/187] ASoC: twl4030: replace codec to component

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Fri Jan 19 01:46:18 CET 2018


Hi Mark, again

> > > > The pmdown_time was 5000 by default (see soc-core.c).
> > > > Ah, in snd_soc_component_driver the pmdown_timme is _not_ pmdown_time,
> > > > but use_pmdown_time boolean...
> > 
> > > Ahh, naming... hmm.. Yes, indeed.
> > > Mark, I know you still not yet accepting these.
> > > We can have 2nd chance to name it ?
> > 
> > Yes, no problem with changes.  This feels like we might want to add a
> > pmdown_time in the component as well.
> 
> Thanks.
> I will change name current .pmdown_time to .use_pmdown_time.
> Adding new pmdown_time on component is different patch.

Because it is very big patch-set.
To avoid patch-bomb on ML, I want to wait other opinion,
and will rework/repost it around -rc1 timing.

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list