[alsa-devel] [PATCH v2 03/16] ASoC: fsl_ssi: Maintain a mask of active streams

Nicolin Chen nicoleotsuka at gmail.com
Mon Jan 15 00:57:21 CET 2018


On Sun, Jan 14, 2018 at 11:34:01PM +0100, Maciej S. Szmigiero wrote:

> > +	bool dir = (&ssi->regvals[TX] == vals) ? TX : RX;
> Using a bool variable for a bit index (and array index in other parts
> of code) looks just wrong.
> 
> Even a simple int would look better IMHO here (and in patch 5 that
> rewrites this line a bit).

Will change to int. Thanks


More information about the Alsa-devel mailing list