[alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias

[Fischer, Christian]

Hello Daniel,

I'm sorry, thats my first official patch :-)
I've now cloned a kernel outside my buildsystem and (hopefully) a new, acceptable patch.
Regards,
Christian

From d06794d98e3ed84ecb1641b74d093366ffff2cba Mon Sep 17 00:00:00 2001
From: Christian Fischer <fischerc at swissphone.de>
Date: Wed, 10 Jan 2018 16:47:51 +0100
Subject: [PATCH v2] ASoC: sgtl5000: fix powerup/down of micbias-voltage

The mic-bias-voltage should get powered up/down automatically.
Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.

Signed-off-by: Christian Fischer <fischerc at swissphone.de>
---
 sound/soc/codecs/sgtl5000.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index f2bb4fe..4973365 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget sgtl5000_dapm_widgets[] = {
 
 	SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event),
 	SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event),
+
+	SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
+	SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),
 };
 
 /* routes for sgtl5000 */
-- 
2.7.4

-----Ursprüngliche Nachricht-----
Von: Daniel Baluta [mailto:daniel.baluta at nxp.com] 
Gesendet: Mittwoch, 10. Januar 2018 15:31
An: Fischer, Christian <fischerc at swissphone.de>; alsa-devel at alsa-project.org
Cc: lgirdwood at gmail.com; broonie at kernel.org; tiwai at suse.com
Betreff: Re: [alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias

On Mi, 2018-01-10 at 14:26 +0000, Fischer, Christian wrote:
> Hello Fabio,
> 
> is it now ok?
> I'm not working with linux-git, so my patch is created by myself.
> 
> Regards,
> Christian
> 
> Signed-off-by: Christian Fischer <fischerc at swissphone.de>

Hi Christian,

This doesn't look good to me. How are creating/sending the patches?

You should update the commit message to include your Signed-off-by tag and then resend the entire patch.

thanks,
Daniel.


> 
> --- sound/soc/codecs/sgtl5000.c
> +++ sound/soc/codecs/sgtl5000.c
> @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget
>  
>  	SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event),
>  	SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event),
> +
> +	SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
> +	SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),
>  };
>  
>  /* routes for sgtl5000 */
> 
> -----Ursprüngliche Nachricht-----
> Von: Fabio Estevam [mailto:festevam at gmail.com]
> Gesendet: Mittwoch, 10. Januar 2018 13:42
> An: Fischer, Christian <fischerc at swissphone.de>
> Cc: alsa-devel at alsa-project.org; Takashi Iwai <tiwai at suse.com>; Mark 
> Brown <broonie at kernel.org>; Liam Girdwood <lgirdwood at gmail.com>
> Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of 
> micbias
> 
> Hi Christian,
> 
> On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc at swissphone.de> wrote:
> > 
> > The bias-bias-voltage should powered up/down automatically.
> > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.
> Thanks for submitting the patch.
> 
> You missed your Signed-off-by tag.
> 
> Please resend it.
> 
> Thanks
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail
> man.alsa-project.org%2Fmailman%2Flistinfo%2Falsa-devel&data=02%7C01%7C
> daniel.baluta%40nxp.com%7C4a771694af314fa7d73008d558362a37
> %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636511912029282885&sdata=Zo42ZJxIxp54YyYLVsFrrRWkDt%2FqByR6uqr8U6pX3iY%3D&reserved=0