[alsa-devel] [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias

Fischer, Christian fischerc at swissphone.de
Wed Jan 10 15:26:32 CET 2018


Hello Fabio,

is it now ok?
I'm not working with linux-git, so my patch is created by myself.

Regards,
Christian

Signed-off-by: Christian Fischer <fischerc at swissphone.de>

--- sound/soc/codecs/sgtl5000.c
+++ sound/soc/codecs/sgtl5000.c
@@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget
 
 	SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event),
 	SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event),
+
+	SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
+	SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),
 };
 
 /* routes for sgtl5000 */

-----Ursprüngliche Nachricht-----
Von: Fabio Estevam [mailto:festevam at gmail.com] 
Gesendet: Mittwoch, 10. Januar 2018 13:42
An: Fischer, Christian <fischerc at swissphone.de>
Cc: alsa-devel at alsa-project.org; Takashi Iwai <tiwai at suse.com>; Mark Brown <broonie at kernel.org>; Liam Girdwood <lgirdwood at gmail.com>
Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of micbias

Hi Christian,

On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc at swissphone.de> wrote:
> The bias-bias-voltage should powered up/down automatically.
> Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.

Thanks for submitting the patch.

You missed your Signed-off-by tag.

Please resend it.

Thanks


More information about the Alsa-devel mailing list