[alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.

[Mark Brown]

On Thu, Jan 04, 2018 at 12:20:06PM +0000, Bard Liao wrote:

> > > Yes, it's supply usage for a micbias. So it didn't take effect with
> > > MICBIAS widget type. Actually, we don't need to set the micbias
> > > power bit for headset mic and we have verified it today. So, I will
> > > send a patch to remove them soon.

> > Are you sure that's likely to be helpful?

> Yes, I checked the register dump and the micbias power bits are
> not set. The register settings will be the same if we remove it,
> and it is verified. On the other hand, the micbias power bits will
> be set and the micbias_event will be invoked after we convert the
> micbias widget type to SUPPLY if we don't remove it.

But are you sure that this was working properly for the Mediatek systems
previously and your and Hans' patches don't actually fix a bug for them
too?  If that's the case then removing the supply hookup would cause a
bug for them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180104/9b140e05/attachment-0001.sig>