[alsa-devel] [PATCH] ASoC: rt5645: add fallback case for jack detection support

[Mark Brown]

On Wed, Jan 03, 2018 at 11:20:38PM +0100, Hans de Goede wrote:

> > +	else if (rt5645_check_dp(&i2c->dev))
> >   		rt5645_parse_dt(rt5645, &i2c->dev);
> > +	else
> > +		rt5645->pdata = jd_mode3_platform_data;

> How about:

> 		rt5645->pdata.jd_mode = 3;

> instead and remove jd_mode3_platform_data and the 2 dmi table entries
> pointing to it ?

I'm not sure it's best practice to remove the entries that have been
explicitly added; on the other hand if the default is jd_mode = 3 then
it's not like we'll be adding any more.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180104/5d5f4b3d/attachment.sig>