[alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.

[Hans de Goede]

Hi,

On 03-01-18 12:28, Mark Brown wrote:
> On Wed, Jan 03, 2018 at 12:01:38PM +0100, Hans de Goede wrote:
> 
>> Right, we have existing machines with a rt5645 and an internal
>> analog mic, but those have been broken sofar (I can confirm
>> this for Cherry Trail based devices, I assume it applies
>> elsewhere) because without the next patch in this series we
>> were never actually enabling micbias. So this change should be
>> fine as analog mic support has been broken sofar anyways AFAIK.
> 
> Are you sure this also applies to non-x86 platforms?

I believe so, yes.

Bard, you've a rt5645 test board which does not use a x86 processor,
right? Can you confirm that the analog microphone input there does
not work with current kernels and needs your
"ASoC: rt5645: add micbias power control select." patch to work?

> This analysis
> needs to be in the changelog.

Ok I will send a v2 with the changelog ammended any comments for
the rest of the series?

Regards,

Hans