[alsa-devel] [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply.

[Mark Brown]

On Tue, Jan 02, 2018 at 07:53:09PM +0100, Hans de Goede wrote:

> Register "micbias1" and "micbias2" to supply widegts as modern drivers do.

> -	SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2,
> -			RT5645_PWR_MB1_BIT, 0),
> -	SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2,
> -			RT5645_PWR_MB2_BIT, 0),
> +	SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2,
> +			RT5645_PWR_MB1_BIT, 0, NULL, 0),
> +	SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2,
> +			RT5645_PWR_MB2_BIT, 0, NULL, 0),

This is a good change to make but we have machines with the rt5645, are
we sure none of them use microphones?  The two widget types work
differently so it needs some checking and possibly machine driver
updates to convert.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180103/2cc7e99f/attachment.sig>