[alsa-devel] [PATCH, alsa-lib] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()

[Takashi Iwai]

On Wed, 28 Feb 2018 16:24:03 +0100,
Mark Brown wrote:
> 
> On Tue, Feb 27, 2018 at 09:35:41PM +0100, Kirill Marinushkin wrote:
> > The values of bclk and fsync are inverted WRT the codec. But the existing
> > solution already works for Broadwell, see the alsa-lib config:
> 
> You should include Jaroslav and Takashi when sending alsa-lib patches.

Yep, please at the next time.
(And, don't stick with an old thread, but refresh a new thread.)

> 
> > +			/* For backwards capability,
> > +			 * "master" == "codec is slave"
> > +			 */
> > +			if (!strcmp(val, "master") ||
> > +			    !strcmp(val, "codec_slave"))
> > +				hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CS;
> > +			else if (!strcmp(val, "codec_master"))
> > +				hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CM;
> 
> Should we warn on use of "master" since it's being deprecated here (and
> might be confusing for users)?

Maybe.  OTOH, it looks fully backward-compatible, so far, so it's not
that confusing yet.


thanks,

Takashi