[alsa-devel] [PATCH, alsa-lib] ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format()

[Mark Brown]

On Tue, Feb 27, 2018 at 09:35:41PM +0100, Kirill Marinushkin wrote:
> The values of bclk and fsync are inverted WRT the codec. But the existing
> solution already works for Broadwell, see the alsa-lib config:

You should include Jaroslav and Takashi when sending alsa-lib patches.

> +			/* For backwards capability,
> +			 * "master" == "codec is slave"
> +			 */
> +			if (!strcmp(val, "master") ||
> +			    !strcmp(val, "codec_slave"))
> +				hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CS;
> +			else if (!strcmp(val, "codec_master"))
> +				hw_cfg->fsync_master = SND_SOC_TPLG_FSYNC_CM;

Should we warn on use of "master" since it's being deprecated here (and
might be confusing for users)?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180228/4ebb6955/attachment.sig>