[alsa-devel] Applied "ASoC: topology: Fix logical inversion in set_link_hw_format()" to the asoc tree

[Mark Brown]

On Mon, Feb 26, 2018 at 06:30:15PM -0800, Pierre-Louis Bossart wrote:
> On 2/26/18 10:34 AM, Kirill Marinushkin wrote:

> > According to the comment, the existing functionality works correctly "WRT the
> > interface". The suggested commit doesn't fix the behaviour: instead, it reverts
> > the logic to "WRT the codec". But the existing implementation is also valid.

> Look at all the machine drivers, they always use the mask by looking at the
> codec side. The comment on top means that the SOC side ('the interface') is
> the dual of the codec side.

> This issue was found during the development of SOF (Sound Open Firmware)
> where we get the reverse of the intended behavior when using the same
> conventions in topology files as in machine drivers.

Is this perhaps something that the earlier firmware is handling inside
the firmware?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180227/c61a3171/attachment.sig>