[alsa-devel] [PATCH] ASoC: imx-wm8962: Use a single private structure

Nicolin Chen nicoleotsuka at gmail.com
Mon Feb 26 19:59:20 CET 2018


On Mon, Feb 26, 2018 at 03:49:57PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> Commit 8f7206d69ab8c ("ASoC: imx-wm8962: Remove global variables")
> ended up by assigning the same value for two different structs:
> 
> struct imx_priv *priv = snd_soc_card_get_drvdata(card);
> struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card);
> 
> Fix it by consolidating all the private data into a single structure.
 
Instead of having this fix to this driver, I would consider about
removing it as I don't see any reason of having it any more since
fsl-asoc-card does the same job. Agree?


More information about the Alsa-devel mailing list