[alsa-devel] [PATCH 1/7] PCI: Restore BARs on runtime resume despite being unbound

[Takashi Iwai]

On Sun, 25 Feb 2018 09:59:00 +0100,
Lukas Wunner wrote:
> 
> On Wed, Feb 21, 2018 at 01:39:34PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, February 21, 2018 10:57:14 AM CET Rafael J. Wysocki wrote:
> > > So if pci_pm_runtime_suspend() is modified to call pci_save_state()
> > > before returning 0 in the !dev->driver case, we can just move the
> > > pci_restore_standard_config() invocation in pci_pm_runtime_resume() up
> > > to the very top and check dev->driver later.
> > 
> > I mean something like the patch below, overall (untested).
> > 
> > Tentatively-signed-off-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> 
> Okay I've tested this successfully now.  I'll have to respin the series
> at least one more time to address the unnecessary initialization Bjorn
> spotted in patch [5/7] and will then replace patch [1/7] with this one.
> 
> I'll wait a few more days before respinning to allow for further
> comments, in particular I'm hoping for feedback from Takashi and
> someone testing this on Optimus/ATPX.

Sorry for the delay.  The patches look like a good cleanup to
straighten the code as well.  Unfortunately I have no hardware to test
right now, but feel free to take my ack for HD-audio related patches:
  Reviewed-by: Takashi Iwai <tiwai at suse.de>


thanks,

Takashi