[alsa-devel] [RESEND PATCH v2 2/2] ASoC: topology: Add missing clock gating parameter when parsing hw_configs

[Kirill Marinushkin]

On 02/21/18 15:50, Andy Shevchenko wrote:
> On Tue, Feb 20, 2018 at 7:44 PM, Kirill Marinushkin
> <k.marinushkin at gmail.com> wrote:
>> Clock gating parameter is a part of `dai_fmt`. It is supported by
>> `alsa-lib` when creating a topology binary file, but ignored by kernel
>> when loading this topology file.
>> +               /* clock gating */
>> +               if (hw_config->clock_gated == SND_SOC_TPLG_DAI_CLK_GATE_GATED)
>> +                       link->dai_fmt |= SND_SOC_DAIFMT_GATED;
>> +               else if (hw_config->clock_gated ==
>> +                        SND_SOC_TPLG_DAI_CLK_GATE_CONT)
> A nit, I would leave it on the same line, even if it ~2-3 characters
> longer than 80.

Hello Andy,

Thank you for the comment.

I think it is important to stay in the length of 80. I understand your point, but from my perspective, the coding style is a higher priority guideline.

Therefore I would prefer to keep this line as it is now.

Beast Regards,
Kirill

>> +                       link->dai_fmt |= SND_SOC_DAIFMT_CONT;
>> +