[alsa-devel] [PATCH 2/3] ASoC: wm9713: Use empty struct initializer

Fabio Estevam festevam at gmail.com
Wed Feb 14 17:49:01 CET 2018


On Wed, Feb 14, 2018 at 2:41 PM, Richard Fitzgerald
<rf at opensource.cirrus.com> wrote:

> This is the actual problem you are trying to fix? The comment about
> { 0 } only clearing the first member is probably bogus, your actual
> problem is that it should have been { NULL } ?

Changing to { NULL } fixes the sparse warning, but that would be a
fragile fix because it relies on the order of the struct members.

If someday the struct changes in a way so that the first member is no
longer a pointer, then we will have issues again.

Using {} is more error prone.


More information about the Alsa-devel mailing list