[alsa-devel] [PATCH v3 1/5] ALSA: emu10k1: remove reserved_page
Takashi Iwai
tiwai at suse.de
Wed Feb 14 07:47:40 CET 2018
On Wed, 14 Feb 2018 00:04:58 +0100,
Maciej S. Szmigiero wrote:
>
> The emu10k1-family chips need the first page (index 0) reserved in their
> page tables for some reason (every emu10k1 driver I've checked does this
> without much of an explanation).
> Using the first page for normal samples results in a broken playback.
>
> However, we already have a dummy page allocated - so called "silent page"
> and, in fact, had always been setting it as the first page in the chip page
> table because an initialization of every entry of the page table to point
> to a silent page happens after and overwrites the reserved_page allocation.
>
> So the only thing remaining to remove the reserved_page allocation is a
> trivial change to the page allocation logic to ignore the first page entry
> and start its allocations from the second entry (index 1).
>
> Signed-off-by: Maciej S. Szmigiero <mail at maciej.szmigiero.name>
> ---
> Changes from v1, v2: None in this patch.
Thanks, applied all 5 patches now.
Takashi
More information about the Alsa-devel
mailing list