[alsa-devel] [PATCH][RFC] ASoC: soc-utils: don't have .use_pmdown_time

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Feb 14 04:01:01 CET 2018


From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

snd_soc_runtime_ignore_pmdown_time() returns "ignore pmdown time"
decision. Then, it collects each component driver's .use_pmdown_time
settings by using AND operation.
But, dummy codec has no reason to ignore/use pmdown time.
Thus, it should has use_pmdown_time=0, it means it doesn't have
decision right of "ignore pmdown time".

Otherwise, dummy codec paired driver's pmdown_time settings doesn't
have meaning. In other words, "ignore pmdown time" is determined
irrespective of the value of paired driver's settings
(= ignore will be 0 by dummy codec).

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
 sound/soc/soc-utils.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c
index 2d9e98b..b70d524 100644
--- a/sound/soc/soc-utils.c
+++ b/sound/soc/soc-utils.c
@@ -290,7 +290,6 @@ static int dummy_dma_open(struct snd_pcm_substream *substream)
 
 static const struct snd_soc_component_driver dummy_codec = {
 	.idle_bias_on		= 1,
-	.use_pmdown_time	= 1,
 	.endianness		= 1,
 	.non_legacy_dai_naming	= 1,
 };
-- 
1.9.1



More information about the Alsa-devel mailing list