[alsa-devel] [PATCH v2] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

Donglin Peng dolinux.peng at gmail.com
Fri Feb 9 16:00:05 CET 2018


On Fri, Feb 9, 2018 at 10:52 PM, Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
> On Fri, Feb 9, 2018 at 4:43 PM, Donglin Peng <dolinux.peng at gmail.com> wrote:
>> There is some duplicate code in soc-core.c, and the kernel provides
>> DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h.
>>
>
> You missed my tag.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
Like this:

There is some duplicate code in soc-core.c, and the kernel provides
DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h.

Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
Signed-off-by: Peng Donglin <dolinux.peng at gmail.com>


More information about the Alsa-devel mailing list