[alsa-devel] [PATCH] ALSA: hda - Revert DSP detection on legacy HD-audio driver
kbuild test robot
lkp at intel.com
Mon Dec 31 21:48:02 CET 2018
Hi Takashi,
I love your patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on next-20181224]
[cannot apply to v4.20]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-hda-Revert-DSP-detection-on-legacy-HD-audio-driver/20190101-022353
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
sound/soc//intel/skylake/skl.c: In function 'skl_probe':
>> sound/soc//intel/skylake/skl.c:976:7: error: 'SND_SKL_PCI_BIND_AUTO' undeclared (first use in this function)
case SND_SKL_PCI_BIND_AUTO:
^~~~~~~~~~~~~~~~~~~~~
sound/soc//intel/skylake/skl.c:976:7: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc//intel/skylake/skl.c:994:7: error: 'SND_SKL_PCI_BIND_LEGACY' undeclared (first use in this function); did you mean 'SND_SKL_PCI_BIND_AUTO'?
case SND_SKL_PCI_BIND_LEGACY:
^~~~~~~~~~~~~~~~~~~~~~~
SND_SKL_PCI_BIND_AUTO
>> sound/soc//intel/skylake/skl.c:997:7: error: 'SND_SKL_PCI_BIND_ASOC' undeclared (first use in this function); did you mean 'SND_SKL_PCI_BIND_AUTO'?
case SND_SKL_PCI_BIND_ASOC:
^~~~~~~~~~~~~~~~~~~~~
SND_SKL_PCI_BIND_AUTO
--
>> sound/soc/intel/skylake/skl.c:976:14: error: undefined identifier 'SND_SKL_PCI_BIND_AUTO'
>> sound/soc/intel/skylake/skl.c:994:14: error: undefined identifier 'SND_SKL_PCI_BIND_LEGACY'
>> sound/soc/intel/skylake/skl.c:997:14: error: undefined identifier 'SND_SKL_PCI_BIND_ASOC'
>> sound/soc/intel/skylake/skl.c:976:14: error: incompatible types for 'case' statement
sound/soc/intel/skylake/skl.c:994:14: error: incompatible types for 'case' statement
sound/soc/intel/skylake/skl.c:997:14: error: incompatible types for 'case' statement
>> sound/soc/intel/skylake/skl.c:976:14: error: Expected constant expression in case statement
sound/soc/intel/skylake/skl.c:994:14: error: Expected constant expression in case statement
sound/soc/intel/skylake/skl.c:997:14: error: Expected constant expression in case statement
sound/soc/intel/skylake/skl.c: In function 'skl_probe':
sound/soc/intel/skylake/skl.c:976:7: error: 'SND_SKL_PCI_BIND_AUTO' undeclared (first use in this function)
case SND_SKL_PCI_BIND_AUTO:
^~~~~~~~~~~~~~~~~~~~~
sound/soc/intel/skylake/skl.c:976:7: note: each undeclared identifier is reported only once for each function it appears in
sound/soc/intel/skylake/skl.c:994:7: error: 'SND_SKL_PCI_BIND_LEGACY' undeclared (first use in this function); did you mean 'SND_SKL_PCI_BIND_AUTO'?
case SND_SKL_PCI_BIND_LEGACY:
^~~~~~~~~~~~~~~~~~~~~~~
SND_SKL_PCI_BIND_AUTO
sound/soc/intel/skylake/skl.c:997:7: error: 'SND_SKL_PCI_BIND_ASOC' undeclared (first use in this function); did you mean 'SND_SKL_PCI_BIND_AUTO'?
case SND_SKL_PCI_BIND_ASOC:
^~~~~~~~~~~~~~~~~~~~~
SND_SKL_PCI_BIND_AUTO
vim +/SND_SKL_PCI_BIND_AUTO +976 sound/soc//intel/skylake/skl.c
d8c2dab838 Jeeja KP 2015-07-09 967
d8c2dab838 Jeeja KP 2015-07-09 968 static int skl_probe(struct pci_dev *pci,
d8c2dab838 Jeeja KP 2015-07-09 969 const struct pci_device_id *pci_id)
d8c2dab838 Jeeja KP 2015-07-09 970 {
d8c2dab838 Jeeja KP 2015-07-09 971 struct skl *skl;
d8c2dab838 Jeeja KP 2015-07-09 972 struct hdac_bus *bus = NULL;
d8c2dab838 Jeeja KP 2015-07-09 973 int err;
d8c2dab838 Jeeja KP 2015-07-09 974
d82b51c855 Pierre-Louis Bossart 2018-12-15 975 switch (skl_pci_binding) {
d82b51c855 Pierre-Louis Bossart 2018-12-15 @976 case SND_SKL_PCI_BIND_AUTO:
d82b51c855 Pierre-Louis Bossart 2018-12-15 977 /*
d82b51c855 Pierre-Louis Bossart 2018-12-15 978 * detect DSP by checking class/subclass/prog-id information
d82b51c855 Pierre-Louis Bossart 2018-12-15 979 * class=04 subclass 03 prog-if 00: no DSP, use legacy driver
d82b51c855 Pierre-Louis Bossart 2018-12-15 980 * class=04 subclass 01 prog-if 00: DSP is present
d82b51c855 Pierre-Louis Bossart 2018-12-15 981 * (and may be required e.g. for DMIC or SSP support)
d82b51c855 Pierre-Louis Bossart 2018-12-15 982 * class=04 subclass 03 prog-if 80: use DSP or legacy mode
d82b51c855 Pierre-Louis Bossart 2018-12-15 983 */
d82b51c855 Pierre-Louis Bossart 2018-12-15 984 if (pci->class == 0x040300) {
d82b51c855 Pierre-Louis Bossart 2018-12-15 985 dev_info(&pci->dev, "The DSP is not enabled on this platform, aborting probe\n");
d82b51c855 Pierre-Louis Bossart 2018-12-15 986 return -ENODEV;
d82b51c855 Pierre-Louis Bossart 2018-12-15 987 }
d82b51c855 Pierre-Louis Bossart 2018-12-15 988 if (pci->class != 0x040100 && pci->class != 0x040380) {
d82b51c855 Pierre-Louis Bossart 2018-12-15 989 dev_err(&pci->dev, "Unknown PCI class/subclass/prog-if information (0x%06x) found, aborting probe\n", pci->class);
d82b51c855 Pierre-Louis Bossart 2018-12-15 990 return -ENODEV;
d82b51c855 Pierre-Louis Bossart 2018-12-15 991 }
d82b51c855 Pierre-Louis Bossart 2018-12-15 992 dev_info(&pci->dev, "DSP detected with PCI class/subclass/prog-if info 0x%06x\n", pci->class);
d82b51c855 Pierre-Louis Bossart 2018-12-15 993 break;
d82b51c855 Pierre-Louis Bossart 2018-12-15 @994 case SND_SKL_PCI_BIND_LEGACY:
d82b51c855 Pierre-Louis Bossart 2018-12-15 995 dev_info(&pci->dev, "Module parameter forced binding with HDaudio legacy, aborting probe\n");
d82b51c855 Pierre-Louis Bossart 2018-12-15 996 return -ENODEV;
d82b51c855 Pierre-Louis Bossart 2018-12-15 @997 case SND_SKL_PCI_BIND_ASOC:
d82b51c855 Pierre-Louis Bossart 2018-12-15 998 dev_info(&pci->dev, "Module parameter forced binding with SKL driver, bypassed detection logic\n");
d82b51c855 Pierre-Louis Bossart 2018-12-15 999 break;
d82b51c855 Pierre-Louis Bossart 2018-12-15 1000 default:
d82b51c855 Pierre-Louis Bossart 2018-12-15 1001 dev_err(&pci->dev, "invalid value for skl_pci_binding module parameter, ignored\n");
d82b51c855 Pierre-Louis Bossart 2018-12-15 1002 break;
d82b51c855 Pierre-Louis Bossart 2018-12-15 1003 }
d82b51c855 Pierre-Louis Bossart 2018-12-15 1004
d8c2dab838 Jeeja KP 2015-07-09 1005 /* we use ext core ops, so provide NULL for ops here */
d8c2dab838 Jeeja KP 2015-07-09 1006 err = skl_create(pci, NULL, &skl);
d8c2dab838 Jeeja KP 2015-07-09 1007 if (err < 0)
d8c2dab838 Jeeja KP 2015-07-09 1008 return err;
d8c2dab838 Jeeja KP 2015-07-09 1009
76f56fae1c Rakesh Ughreja 2018-06-01 1010 bus = skl_to_bus(skl);
d8c2dab838 Jeeja KP 2015-07-09 1011
76f56fae1c Rakesh Ughreja 2018-06-01 1012 err = skl_first_init(bus);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1013 if (err < 0) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1014 dev_err(bus->dev, "skl_first_init failed with err: %d\n", err);
d8c2dab838 Jeeja KP 2015-07-09 1015 goto out_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1016 }
d8c2dab838 Jeeja KP 2015-07-09 1017
4b235c43de Vinod Koul 2016-02-19 1018 skl->pci_id = pci->device;
4b235c43de Vinod Koul 2016-02-19 1019
2e9dc2b645 Vinod Koul 2016-06-22 1020 device_disable_async_suspend(bus->dev);
2e9dc2b645 Vinod Koul 2016-06-22 1021
87b2bdf022 Jeeja KP 2015-10-07 1022 skl->nhlt = skl_nhlt_init(bus->dev);
87b2bdf022 Jeeja KP 2015-10-07 1023
979cf59acc Wei Yongjun 2016-08-12 1024 if (skl->nhlt == NULL) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1025 #if !IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1026 dev_err(bus->dev, "no nhlt info found\n");
979cf59acc Wei Yongjun 2016-08-12 1027 err = -ENODEV;
ab1b732d53 Vinod Koul 2017-05-04 1028 goto out_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1029 #else
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1030 dev_warn(bus->dev, "no nhlt info found, continuing to try to enable HDaudio codec\n");
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1031 #endif
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1032 } else {
87b2bdf022 Jeeja KP 2015-10-07 1033
0cf5a17159 Subhransu S. Prusty 2017-01-11 1034 err = skl_nhlt_create_sysfs(skl);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1035 if (err < 0) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1036 dev_err(bus->dev, "skl_nhlt_create_sysfs failed with err: %d\n", err);
0cf5a17159 Subhransu S. Prusty 2017-01-11 1037 goto out_nhlt_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1038 }
0cf5a17159 Subhransu S. Prusty 2017-01-11 1039
4b235c43de Vinod Koul 2016-02-19 1040 skl_nhlt_update_topology_bin(skl);
4b235c43de Vinod Koul 2016-02-19 1041
bc2bd45b1f Sriram Periyasamy 2017-11-22 1042 /* create device for dsp clk */
bc2bd45b1f Sriram Periyasamy 2017-11-22 1043 err = skl_clock_device_register(skl);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1044 if (err < 0) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1045 dev_err(bus->dev, "skl_clock_device_register failed with err: %d\n", err);
bc2bd45b1f Sriram Periyasamy 2017-11-22 1046 goto out_clk_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1047 }
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1048 }
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1049
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1050 pci_set_drvdata(skl->pci, bus);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1051
bc2bd45b1f Sriram Periyasamy 2017-11-22 1052
752c93aa72 Pankaj Bharadiya 2017-12-18 1053 err = skl_find_machine(skl, (void *)pci_id->driver_data);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1054 if (err < 0) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1055 dev_err(bus->dev, "skl_find_machine failed with err: %d\n", err);
c286b3f960 Jeeja KP 2016-05-05 1056 goto out_nhlt_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1057 }
cc18c5fdcd Vinod Koul 2015-11-05 1058
2a29b200c6 Jeeja KP 2015-10-07 1059 err = skl_init_dsp(skl);
2a29b200c6 Jeeja KP 2015-10-07 1060 if (err < 0) {
2a29b200c6 Jeeja KP 2015-10-07 1061 dev_dbg(bus->dev, "error failed to register dsp\n");
752c93aa72 Pankaj Bharadiya 2017-12-18 1062 goto out_nhlt_free;
2a29b200c6 Jeeja KP 2015-10-07 1063 }
0c8ba9d285 Jayachandran B 2015-12-18 1064 skl->skl_sst->enable_miscbdcge = skl_enable_miscbdcge;
fc9fdd61c4 Sanyog Kale 2018-03-13 1065 skl->skl_sst->clock_power_gating = skl_clock_power_gating;
7f981bdcf5 Pierre-Louis Bossart 2018-12-07 1066
ec8ae5703d Vinod Koul 2016-08-04 1067 if (bus->mlcap)
76f56fae1c Rakesh Ughreja 2018-06-01 1068 snd_hdac_ext_bus_get_ml_capabilities(bus);
0505700104 Jeeja KP 2015-07-09 1069
ab1b732d53 Vinod Koul 2017-05-04 1070 snd_hdac_bus_stop_chip(bus);
ab1b732d53 Vinod Koul 2017-05-04 1071
d8c2dab838 Jeeja KP 2015-07-09 1072 /* create device for soc dmic */
d8c2dab838 Jeeja KP 2015-07-09 1073 err = skl_dmic_device_register(skl);
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1074 if (err < 0) {
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1075 dev_err(bus->dev, "skl_dmic_device_register failed with err: %d\n", err);
2a29b200c6 Jeeja KP 2015-10-07 1076 goto out_dsp_free;
f231c34ca9 Pierre-Louis Bossart 2018-12-07 1077 }
d8c2dab838 Jeeja KP 2015-07-09 1078
ab1b732d53 Vinod Koul 2017-05-04 1079 schedule_work(&skl->probe_work);
d8c2dab838 Jeeja KP 2015-07-09 1080
d8c2dab838 Jeeja KP 2015-07-09 1081 return 0;
d8c2dab838 Jeeja KP 2015-07-09 1082
2a29b200c6 Jeeja KP 2015-10-07 1083 out_dsp_free:
2a29b200c6 Jeeja KP 2015-10-07 1084 skl_free_dsp(skl);
bc2bd45b1f Sriram Periyasamy 2017-11-22 1085 out_clk_free:
bc2bd45b1f Sriram Periyasamy 2017-11-22 1086 skl_clock_device_unregister(skl);
c286b3f960 Jeeja KP 2016-05-05 1087 out_nhlt_free:
c286b3f960 Jeeja KP 2016-05-05 1088 skl_nhlt_free(skl->nhlt);
d8c2dab838 Jeeja KP 2015-07-09 1089 out_free:
76f56fae1c Rakesh Ughreja 2018-06-01 1090 skl_free(bus);
d8c2dab838 Jeeja KP 2015-07-09 1091
d8c2dab838 Jeeja KP 2015-07-09 1092 return err;
d8c2dab838 Jeeja KP 2015-07-09 1093 }
d8c2dab838 Jeeja KP 2015-07-09 1094
:::::: The code at line 976 was first introduced by commit
:::::: d82b51c855a20eb456ac09f2f40ea98312373263 ALSA: HD-Audio: SKL+: force HDaudio legacy or SKL+ driver selection
:::::: TO: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
:::::: CC: Takashi Iwai <tiwai at suse.de>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 66742 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190101/7819d469/attachment-0001.bin>
More information about the Alsa-devel
mailing list