[alsa-devel] [PATCH 2/4] ASoC: wm8904: Automatically enable FLL when selected

[Mark Brown]

On Fri, Dec 21, 2018 at 11:52:27AM +0000, Charles Keepax wrote:
> On Wed, Dec 19, 2018 at 09:11:15PM +0100, Michał Mirosław wrote:

> > +		if (!wm8904->fll_fout) {
> > +			int ret = wm8904_set_fll(component, WM8904_FLL_MCLK, WM8904_FLL_MCLK,
> > +						 clk_get_rate(wm8904->mclk), 12288000);
> > +			if (ret)
> > +				return ret;
> > +		}

> What is your thinking on selecting a 12.28MHz clock? Will this
> not cause issues with say 44.1k playback?

The driver just shouldn't be making decisions like this at all, either
generic code or a machine driver should do so.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20181221/ede6246e/attachment.sig>