[alsa-devel] [PATCH v3 1/2] ASoC: cs35l36: Add support for Cirrus CS35L36 Amplifier

[kbuild test robot]

Hi James,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/James-Schulman/ASoC-cs35l36-Add-support-for-Cirrus-CS35L36-Amplifier/20181218-063001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from sound/soc/codecs/cs35l36.c:34:0:
>> include/sound/cs35l36.h:15:8: error: redefinition of 'struct irq_cfg'
    struct irq_cfg {
           ^~~~~~~
   In file included from arch/x86/include/asm/smp.h:15:0,
                    from include/linux/smp.h:68,
                    from include/linux/topology.h:33,
                    from include/linux/gfp.h:9,
                    from include/linux/umh.h:4,
                    from include/linux/kmod.h:22,
                    from include/linux/module.h:13,
                    from sound/soc/codecs/cs35l36.c:11:
   arch/x86/include/asm/io_apic.h:156:8: note: originally defined here
    struct irq_cfg;
           ^~~~~~~

coccinelle warnings: (new ones prefixed by >>)

>> sound/soc/codecs/cs35l36.c:513:5-8: Unneeded variable: "ret". Return "0" on line 554

Please review and possibly fold the followup patch.

vim +15 include/sound/cs35l36.h

    13	
    14	/* INT/GPIO pin configuration */
  > 15	struct irq_cfg {
    16		bool is_present;
    17		int irq_drv_sel;
    18		int irq_pol;
    19		int irq_gpio_sel;
    20	};
    21	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 66108 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20181218/a6dfb881/attachment-0001.bin>