[alsa-devel] Need help fixing pop/click artifacts in an ASOC driver

Mark Brown broonie at kernel.org
Mon Dec 17 18:39:30 CET 2018


On Mon, Dec 17, 2018 at 09:03:33AM -0600, Pierre-Louis Bossart wrote:

> I started prototyping a different approach where the codec driver passes the
> regmap information to the clock driver. What's missing in the patchset is
> the addition of a clock control in the machine driver, and logic added so
> that rate  change can only be done in a hw_params if there was a complete
> stop and reset on a DAPM_OFF event. compile-tested only for now.

> https://github.com/plbossart/sound/commits/hifiberry/clks

That looks a lot like the CODEC should be exporting a GPIO driver so the
machine driver doesn't actually need the regmap?  The only register
touched is _GPIO_CONTROL_1.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20181217/ac9cc63d/attachment.sig>


More information about the Alsa-devel mailing list