[alsa-devel] ASoC: Intel: sst: Missing IRQ at index 5 on BYT-T device

[Antonio Ospite]

On Sun, 16 Dec 2018 20:07:30 +0100
Hans de Goede <hdegoede at redhat.com> wrote:

> Hi,
> 
> On 16-12-18 19:54, Stephan Gerhold wrote:
[...] 
> > Unlike many of the other DSDT dumps I've looked at, there is only one
> > interrupt listed. Full ACPI DSDT table is at [1].
> > 
> > Since there is no IRQ at index 5, platform_get_irq will return -ENXIO.
> > Couldn't we fall back to index 0 in this case? I would say that if the
> > seemingly "correct" IRQ at index 5 does not even exist, we still have
> > a better chance of picking the right one if we try the one at index 0.
> > Or we could check the number of interrupts that are actually available.
> 
> If I'm not mistaken then you already mentioned in another thread
> (the "tusb1210 probe of dwc3.0.auto.ulpi fails with EBUSY on 4.19+")
> thread that the DSTD of this Andriod only device has several bugs in
> there such as wrong GPIOs in some places, etc. and you need to do a
> DSDT override anyways to get some things to work, right ?
> 
> In that case I believe it would be best to just also patch up this
> part of the DSDT in your override and leave the current kernel code
> as is.
> 

FWIW that is what I did when playing with a Teclast X98 Air 3G some
years ago, see:
https://git.ao2.it/Teclast-X98-Air-3G_C6J6_custom_DSDT.git/

In my case I just had to fix the ordering:
https://git.ao2.it/Teclast-X98-Air-3G_C6J6_custom_DSDT.git/commitdiff/f718ea7d184cf266d7b5453124139b1c627221e6

It's been a while tho, I just committed and pushed the change now
because I had forgotten back in the day.

The Makefile in the repository contains some pointers about how to build
a DSDT override, what is missing is that you still have to manually
append the original initrd to the file created by the Makefile.

Ciao,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?