[alsa-devel] [PATCH] ALSA: hda: add mute LED support for HP EliteBook 840 G4

Mantas Mikulėnas grawity at gmail.com
Sun Dec 16 14:48:53 CET 2018


On Sun, Dec 16, 2018 at 11:15 AM Takashi Iwai <tiwai at suse.de> wrote:
>
> On Sat, 15 Dec 2018 17:43:54 +0100,
> Mantas Mikulėnas wrote:
> >
> > Tested with 4.19.8.
> >
> > (Existing entries for similar models use CXT_FIXUP_HP_DOCK, which might
> > be a better choice here as well, but that's far beyond my knowledge --
> > and I don't have a dock to test it with either.)
>
> If CXT_FIXUP_HP_DOCK works for you, I guess it's better to use it.
> As you guessed, this is likely a better-matching one for EliteBook.

Yes, it seems to work fine for me (the LEDs are controlled correctly
and I haven't noticed any negative effects).

> Also, the entries are (mostly) sorted in the PCI SSID order.  Could
> you put your new entry in the right place?

Will do.

-- 
Mantas Mikulėnas


More information about the Alsa-devel mailing list