[alsa-devel] [PATCH v3 1/1] ASoC: Intel: kbl_rt5660: Add a new machine driver for kbl with rt5660

[Hui Wang]

On 2018/12/13 下午10:32, Pierre-Louis Bossart wrote:
>
> On 12/13/18 7:02 AM, Hui Wang wrote:
>> The new Dell IoT platform uses kabylake + alc3277 codec, and alc3277
>> shares the driver with the codec rt5660, here we generate a new
>> machine driver based on kbl_da7219_max98357a.
>>
>> The audio design on this IoT platform is as below:
>>   - Intel kabylake platform
>>   - connect the codec ALC3277 via SSP0
>>   - line-out and line-in with Micbias jacks
>>   - line-out mute control and jack detection of line-out and line-in
>>   - two HDMI ports with audio capability
>>
>> Signed-off-by: Hui Wang <hui.wang at canonical.com>
>
> Looks good to me, thanks for the updates.
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>
> One question for Hui: are you planning to provide the topology file 
> and UCM settings for this platform? I've been trying to expand the 
> tests lately and without those two configuration files it'll be 
> difficult to add this platform.

For topology file, we just used the existing file for sklrt286 (alsatplg 
-c sklrt286/sklrt286.conf -O /lib/firmware/dfw_sst.bin),  the skl_rt286 
also connects the codec with SSP0 in I2S mode, it is a similar design as 
this IoT board. And the generated dfw_sst.bin worked well on this IoT board.

So far we don't have ability to edit/generate topology conf file 
manually,  and recently we had a new project to support the soc-dmic on 
cannonlake/coffeelake (8086a348), one of the blocked issues is the 
topology firmware,  probably need your help in the near future.


For UCM setting, I plan to send it to review next week. Since this IoT 
platform only runs ubuntu core and ubuntu server, there is no pulseaudio 
on it,  there is no need to write a UCM setting so far, we just executed 
"amixer sset" or "alsactl -c asound.state-work-ok restore" on command 
line, I plan to install ubuntu desktop on this IoT platform to prepare 
UCM setting next week.


Thanks,

Hui.


>
>> ---
>>   sound/soc/intel/boards/Kconfig                |  10 +
>>   sound/soc/intel/boards/Makefile               |   2 +
>>   sound/soc/intel/boards/kbl_rt5660.c           | 543 ++++++++++++++++++
>>   .../intel/common/soc-acpi-intel-kbl-match.c   |  10 +