[alsa-devel] [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport [UNSCANNED]

[Charles Keepax]

On Thu, Aug 30, 2018 at 04:41:40PM +0100, Mark Brown wrote:
> On Thu, Aug 30, 2018 at 09:38:01AM +1000, Matt Flax wrote:
> > The cs4265 uses 32 bit transport on the I2S bus. This patch enables native
> > 32 bit mode for machine drivers which use this sound card driver.
> > 
> > Signed-off-by: Matt Flax <flatmax at flatmax.org>
> > ---
> > 
> > No changes from v1, however have tested the intended functionality and
> > list discussion had firmed up its purpose.
> > ---
> 
> Charles?

I think this one looks fine to me:

Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Only slightly doubt I had was that the CODEC doesn't actually
support 32bit only 24bit. It will however happily accept the
32-bit from the bus you just loose some precision whilst playing
it, so feels like that is basically the same as supporting it to
me. Unless I have missed something again :-)

Thanks,
Charles