[alsa-devel] [PATCH] ASoC: Convert to using %pOFn instead of device_node.name

Andy Shevchenko andy.shevchenko at gmail.com
Tue Aug 28 09:57:43 CEST 2018


On Tue, Aug 28, 2018 at 4:57 AM Rob Herring <robh at kernel.org> wrote:

> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.

> +       snprintf((char *)dai->platform_name, DAI_NAME_SIZE, "%llx.%pOFn",
> +                (unsigned long long) res.start, dma_channel_np);

I understand that is not the part of the change, but wouldn't be good
to replace that ugly casting with proper specifier as well?
I mean
%pa ... &res.start

> +                       dev_err(&pdev->dev, "%pOFn sync own reference\n",
> +                               np);

One line?

-- 
With Best Regards,
Andy Shevchenko


More information about the Alsa-devel mailing list