[alsa-devel] [PATCH v2] ASoC: sigmadsp: safeload should not have lower byte limit

[Lars-Peter Clausen]

On 08/23/2018 10:26 AM, Danny Smith wrote:
> Fixed range in safeload conditional to allow safeload to up to 20 bytes,
> without a lower limit.
> 
> Signed-off-by: Danny Smith <dannys at axis.com>

I'd have liked the commit message to be a bit more verbose about the why.
But either way:

Acked-by: Lars-Peter Clausen <lars at metafoo.de>


> ---
>  sound/soc/codecs/sigmadsp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
> index d53680ac78e4..6df158669420 100644
> --- a/sound/soc/codecs/sigmadsp.c
> +++ b/sound/soc/codecs/sigmadsp.c
> @@ -117,8 +117,7 @@ static int sigmadsp_ctrl_write(struct sigmadsp *sigmadsp,
>  	struct sigmadsp_control *ctrl, void *data)
>  {
>  	/* safeload loads up to 20 bytes in a atomic operation */
> -	if (ctrl->num_bytes > 4 && ctrl->num_bytes <= 20 && sigmadsp->ops &&
> -	    sigmadsp->ops->safeload)
> +	if (ctrl->num_bytes <= 20 && sigmadsp->ops && sigmadsp->ops->safeload)
>  		return sigmadsp->ops->safeload(sigmadsp, ctrl->addr, data,
>  			ctrl->num_bytes);
>  	else
>