[alsa-devel] [PATCH v7 7/7] ASoC: Intel: Skylake: add option to control HDAudio + DSP usage

[Takashi Iwai]

On Wed, 22 Aug 2018 17:36:44 +0200,
Pierre-Louis Bossart wrote:
> 
> On 8/22/18 3:03 AM, Takashi Iwai wrote:
> > On Fri, 17 Aug 2018 22:37:23 +0200,
> > Pierre-Louis Bossart wrote:
> >>
> >> Add option to explicitly enable HDAudio + DSP usage.
> >>
> >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> >> ---
> >>   sound/soc/intel/Kconfig       | 9 +++++++++
> >>   sound/soc/intel/skylake/skl.c | 8 ++++++++
> >>   2 files changed, 17 insertions(+)
> >>
> >> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> >> index 0caa1f4eb94d..3ee6a407eb08 100644
> >> --- a/sound/soc/intel/Kconfig
> >> +++ b/sound/soc/intel/Kconfig
> >> @@ -117,6 +117,15 @@ config SND_SOC_INTEL_SKYLAKE
> >>   	  GeminiLake or CannonLake platform with the DSP enabled in the BIOS
> >>   	  then enable this option by saying Y or m.
> >>   +config SND_SOC_INTEL_SKYLAKE_HDA_DSP
> >> +	bool "Enable HDAudio Codec + DSP support"
> >> +	depends on SND_SOC_INTEL_SKYLAKE
> >> +	help
> >> +	  If you have a Intel Skylake+ platform with the DSP enabled in
> >> +	  the BIOS and an HDAudio codec, then enable this option by saying Y
> >> +	  This option will only have an effect if there are no ACPI-enumerated
> >> +	  audio devices (I2C, SoundWire).
> >
> > As mentioned in the previous patchset, this kind of control should be
> > better provided as a module option.  If this influences on the module
> > dependency, it'd make sense to do as Kconfig.  But this doesn't look
> > so, and it's rather a sort of runtime control to match with the
> > deployed hardware configuration.
> 
> In the previous patch set, there were two Kconfigs. One of them was
> for debug, but I removed it since it wasn't such a good idea. This one
> is more static and can be enabled by default by a distro. It's not
> intended to be changed at runtime. I just wanted to leave it out for
> now to make sure there is no change to existing platforms. I can
> remove it if you feel it's unnecessary.

I belive this is superfluous, then.


thanks,

Takashi