[alsa-devel] [PATCH - hwmixvolume 1/9] hwmixvolume: replace PyGTK with gobject-introspection

Takashi Iwai tiwai at suse.de
Fri Aug 10 16:56:47 CEST 2018


On Wed, 08 Aug 2018 17:56:29 +0200,
Emmanuel Gil Peyrot wrote:
> 
> This doesn’t work yet, we require Gtk 3.0 rather than 2.0 and the API
> changed quite a lot.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>

Thanks for the patches.  Most of changes look good, but also most of
patches have no change log at all.  That's already a bad sign.

Could you give some details, especially why the change is needed, in
each patch and resubmit as a patchset?  At best, send with a cover
letter and a thread as a patch set at the next time (git-send-email
can manage it well).


Takashi


More information about the Alsa-devel mailing list