[alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through
Mark Brown
broonie at kernel.org
Thu Aug 9 15:46:31 CEST 2018
On Thu, Aug 09, 2018 at 01:23:58PM +0200, Lars-Peter Clausen wrote:
> On 08/09/2018 11:30 AM, Mark Brown wrote:
> It is. But it might make sense to re-order the code to look like
>
> case 54000000:
> if (source != ADAV80X_PLL_SRC_XIN)
> return -EINVAL;
>
> pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
> break;
> It is just as many lines added when adding the /* fall through */, but it
> makes it more obvious what is going on.
Yes, it's much more obvious.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180809/b23f0806/attachment.sig>
More information about the Alsa-devel
mailing list