[alsa-devel] [PATCH] soundwire: intel: Fix uninitialized adev deref

[Pierre-Louis Bossart]

On 8/7/18 1:41 AM, Vinod Koul wrote:
> In case of error, we can dereference uninitialized 'adev'
> 
> drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
> error: uninitialized symbol 'adev'.
> 
> Fix that by not using adev for warn print and make it pr_err.
> 
> Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
> Signed-off-by: Vinod Koul <vkoul at kernel.org>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

> ---
>   drivers/soundwire/intel_init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index d1ea6b4d0ad3..5c8a20d99878 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
>   	struct acpi_device *adev;
>   
>   	if (acpi_bus_get_device(handle, &adev)) {
> -		dev_err(&adev->dev, "Couldn't find ACPI handle\n");
> +		pr_err("%s: Couldn't find ACPI handle\n", __func__);
>   		return AE_NOT_FOUND;
>   	}
>   
>