[alsa-devel] [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

[Srinivas Kandagatla]

Thanks for the review.

On 31/07/18 21:43, Rob Herring wrote:
>> +
>> +- reset-gpio:
> reset-gpios
> 
Yep, reset-gpios makes more inline with others!
>> +	Usage: required
>> +	Value type: <String Array>
>> +	Definition: Reset gpio line
>> +
>> +- qcom,ifd:
>> +	Usage: required
>> +	Value type: <phandle>
>> +	Definition: SLIM interface device
> Wouldn't this be the parent?
> 
No, Interface device is just like other slim device and is part of 
SLIMbus Component and has a unique address. Every SLIMbus component has 
one interface device.
...
>> +
>> +codec at 1{
> audio-codec at 1
> 
Yep, I will fix this in next version.

>> +	compatible = "slim217,1a0";
>> +	reg  = <1 0>;

Thanks,
srini