[alsa-devel] [PATCH v2 1/2] ASoC: mt6797: switch to SPDX license tag
Matthias Brugger
matthias.bgg at gmail.com
Fri Apr 27 11:27:38 CEST 2018
On 04/27/2018 11:23 AM, Sean Wang wrote:
> Ryder and Garlic are not actual authors.
>
> There are totally copy-n-paste errors on Author fields when KaiChieh is
> making the 1st version.
>
> also can see
>
> http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013036.html
>
> http://lists.infradead.org/pipermail/linux-mediatek/2018-April/013036.html
>
>
Sorry I didn't read these two emails.
Reviewed-by: Matthias Brugger <matthias.bgg at gmail.com>
> On Fri, 2018-04-27 at 11:15 +0200, Matthias Brugger wrote:
>>
>> On 04/27/2018 03:54 AM, KaiChieh Chuang wrote:
>>> Signed-off-by: KaiChieh Chuang <kaichieh.chuang at mediatek.com>
>>> ---
>>> sound/soc/mediatek/mt6797/Makefile | 13 +------------
>>> sound/soc/mediatek/mt6797/mt6797-afe-clk.c | 21 ++++++---------------
>>> sound/soc/mediatek/mt6797/mt6797-afe-clk.h | 10 +---------
>>> sound/soc/mediatek/mt6797/mt6797-afe-common.h | 10 +---------
>>> sound/soc/mediatek/mt6797/mt6797-afe-pcm.c | 21 ++++++---------------
>>> sound/soc/mediatek/mt6797/mt6797-interconnection.h | 10 +---------
>>> sound/soc/mediatek/mt6797/mt6797-mt6351.c | 21 ++++++---------------
>>> sound/soc/mediatek/mt6797/mt6797-reg.h | 12 ++----------
>>> 8 files changed, 24 insertions(+), 94 deletions(-)
>>>
>>
>> [...]
>>
>>> diff --git a/sound/soc/mediatek/mt6797/mt6797-mt6351.c b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
>>> index d42a9d9fbf3e..9e5866d6819a 100644
>>> --- a/sound/soc/mediatek/mt6797/mt6797-mt6351.c
>>> +++ b/sound/soc/mediatek/mt6797/mt6797-mt6351.c
>>> @@ -1,18 +1,9 @@
>>> -/*
>>> - * mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
>>> - *
>>> - * Copyright (c) 2018 MediaTek Inc.
>>> - * Author: Ryder Lee <ryder.lee at mediatek.com>
>>> - *
>>> - * This program is free software; you can redistribute it and/or modify
>>> - * it under the terms of the GNU General Public License version 2 and
>>> - * only version 2 as published by the Free Software Foundation.
>>> - *
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> - * GNU General Public License for more details.
>>> - */
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +//
>>> +// mt6797-mt6351.c -- MT6797 MT6351 ALSA SoC machine driver
>>> +//
>>> +// Copyright (c) 2018 MediaTek Inc.
>>> +// Author: KaiChieh Chuang <kaichieh.chuang at mediatek.com>
>>
>> As we said in the last version, you should not delete Ryder from the author list.
>>
>>>
>>> #include <linux/module.h>
>>> #include <sound/soc.h>
>>> diff --git a/sound/soc/mediatek/mt6797/mt6797-reg.h b/sound/soc/mediatek/mt6797/mt6797-reg.h
>>> index 3330f73fc8bb..ffb55367f59f 100644
>>> --- a/sound/soc/mediatek/mt6797/mt6797-reg.h
>>> +++ b/sound/soc/mediatek/mt6797/mt6797-reg.h
>>> @@ -1,17 +1,9 @@
>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>> /*
>>> * mt6797-reg.h -- Mediatek 6797 audio driver reg definition
>>> *
>>> * Copyright (c) 2018 MediaTek Inc.
>>> - * Author: Garlic Tseng <garlic.tseng at mediatek.com>
>>> - *
>>> - * This program is free software; you can redistribute it and/or modify
>>> - * it under the terms of the GNU General Public License version 2 and
>>> - * only version 2 as published by the Free Software Foundation.
>>> - *
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>>> - * GNU General Public License for more details.
>>> + * Author: KaiChieh Chuang <kaichieh.chuang at mediatek.com>
>>
>> Same here, Garlic is an author as well, don't delete him from the comment.
>>
>> Regards,
>> Matthias
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
>
More information about the Alsa-devel
mailing list