[alsa-devel] [PATCH 0/8] ALSA: Hardening for potential Spectre v1

Takashi Iwai tiwai at suse.de
Tue Apr 24 09:56:11 CEST 2018


Hi,

this is a patchset to cover the potential issues wrt Spectre v1 that
were spotted out recently by Smatch:
  https://marc.info/?l=linux-kernel&m=152411496503418&w=2

Although all reports for sound/* seem like no serious issues, it's
better to cover potential usages than a too late sorry.

The first patch is basically irrelevant for Spectre but a preliminary
fix for the following fix.  Most of the rest patches are
straightforward, but the second one, the fix for OSS emulation, became
a fair amount of code refactoring in the end.

An open question is whether we should put Cc-to-stable to these
fixes.  Maybe yes, although we've never proven that the problem would
actually exist, the issue is still "hot", so people may want to see
them more-or-less covered...


thanks,

Takashi

===

Takashi Iwai (8):
  ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device
  ALSA: seq: oss: Hardening for potential Spectre v1
  ALSA: control: Hardening for potential Spectre v1
  ALSA: hda: Hardening for potential Spectre v1
  ALSA: opl3: Hardening for potential Spectre v1
  ALSA: asihpi: Hardening for potential Spectre v1
  ALSA: hdspm: Hardening for potential Spectre v1
  ALSA: rme9652: Hardening for potential Spectre v1

 include/sound/control.h            |  7 +++-
 sound/core/seq/oss/seq_oss_event.c | 15 ++++---
 sound/core/seq/oss/seq_oss_midi.c  |  2 +
 sound/core/seq/oss/seq_oss_synth.c | 85 ++++++++++++++++++++++----------------
 sound/core/seq/oss/seq_oss_synth.h |  3 +-
 sound/drivers/opl3/opl3_synth.c    |  7 +++-
 sound/pci/asihpi/hpimsginit.c      | 13 ++++--
 sound/pci/asihpi/hpioctl.c         |  4 +-
 sound/pci/hda/hda_hwdep.c          | 12 +++++-
 sound/pci/rme9652/hdspm.c          | 24 ++++++-----
 sound/pci/rme9652/rme9652.c        |  6 ++-
 11 files changed, 113 insertions(+), 65 deletions(-)

-- 
2.16.3



More information about the Alsa-devel mailing list