[alsa-devel] [PATCH v4 07/13] soundwire: Add stream configuration APIs

[Pierre-Louis Bossart]

>>> +
>>> +	if (!bus->params.bandwidth) {
>>> +		bus->params.row = 0;
>>> +		bus->params.col = 0;
>>> +		goto exit;
>>
>> What is the intent with this test+goto? Shouldn't you program the parameters
>> if you want to change the frame shape?
> 
> hmmm that seems correct point to me, but then we are going idle and should
> ideally power down. Let me check again if that is the reason.

what about clock stop? what about the default frame shape specified in 
the DisCo spec? I don't see the reason why we'd go to 48x2 - especially 
on Intel platforms where we'll typically use  50x2 to remain aligned 
with a 48kHz frame rate.