[alsa-devel] [PATCH v4 02/13] soundwire: Add support for SoundWire stream management

[Pierre-Louis Bossart]

>>
>>> +			(stream->params.bps != stream_config->bps)) {
>>> +		dev_err(dev, "bps not matching, stream:%s", stream->name);
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	stream->type = stream_config->type;
>>> +	stream->params.rate = stream_config->frame_rate;
>>> +	stream->params.bps = stream_config->bps;
>>> +	if (is_slave)
>>> +		stream->params.ch_count += stream_config->ch_count;
>>
>> Add comment or TODO that this does not work in device-to-device
>> communication. This is a known limitation that needs to be tracked.
> 
> Yes limitation for a feature that we dont support yet. So i dont think we
> need to do anything atm for this. When the support for device-to-device
> shows up, that would update this and other conditions valid only for specific
> cases.

so if you don't support it yet, add a comment that this will have to be 
modified. This is all I am asking so that this limitation is known and 
the parts that have to be changed identified.