[alsa-devel] [PATCH] ASoC: fsl_esai: Fix divisor calculation failure at lower ratio

Fabio Estevam festevam at gmail.com
Mon Apr 9 03:34:01 CEST 2018


Hi Nicolin,

On Sun, Apr 8, 2018 at 8:57 PM, Nicolin Chen <nicoleotsuka at gmail.com> wrote:
> When the desired ratio is less than 256, the savesub (tolerance)
> in the calculation would become 0. This will then fail the loop-
> search immediately without reporting any errors.
>
> But if the ratio is smaller enough, there is no need to calculate
> the tolerance because PM divisor alone is enough to get the ratio.
>
> So a simple fix could be just to set PM directly instead of going
> into the loop-search.
>
> Reported-by: Marek Vasut <marex at denx.de>
> Signed-off-by: Nicolin Chen <nicoleotsuka at gmail.com>
> Cc: Marek Vasut <marex at denx.de>

If this fixes Marek's usecase then I think we should also add:

Cc: <stable at vger.kernel.org>

Thanks


More information about the Alsa-devel mailing list