[alsa-devel] [PATCH 3/6] ASoC: rsnd: DVC kctrl sets once

[Sergei Shtylyov]

Hello!

On 9/29/2017 3:09 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> Same DVC might be used few times if system/platform is using MIX.
> For example below case.
> 
> 	DAI0 playback = <&src0 &ctu02 &mix0 &dvc0 &ssi0>;
> 	DAI1 playback = <&src2 &ctu03 &mix0 &dvc0 &ssi0>;
> 
> This case, ALSA will have DVC,0 and DVC,1 kcontrol interfaces,
> but these are same DVC. This is confusable.

    Confusing.

> This patch adds new flags and avoid such case.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> Tested-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx at renesas.com>
> ---
>   sound/soc/sh/rcar/dvc.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/sound/soc/sh/rcar/dvc.c b/sound/soc/sh/rcar/dvc.c
> index 1743ade..b4c4ff2 100644
> --- a/sound/soc/sh/rcar/dvc.c
> +++ b/sound/soc/sh/rcar/dvc.c
> @@ -44,8 +44,11 @@ struct rsnd_dvc {
>   	struct rsnd_kctrl_cfg_s ren;	/* Ramp Enable */
>   	struct rsnd_kctrl_cfg_s rup;	/* Ramp Rate Up */
>   	struct rsnd_kctrl_cfg_s rdown;	/* Ramp Rate Down */
> +	u32 flags;
>   };
>   
> +#define KCTRL_INITIALIZEED	(1 << 0)

    One E is enough. :-)

[...]

MBR, Sergei