[alsa-devel] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()
SF Markus Elfring
elfring at users.sourceforge.net
Sun Sep 24 09:06:12 CEST 2017
> 668 if (!amdtp_stream_wait_callback(&bebob->tx_stream,
> 669 CALLBACK_TIMEOUT)) {
> 670 amdtp_stream_stop(&bebob->tx_stream);
> 671 amdtp_stream_stop(&bebob->rx_stream);
> 672 break_both_connections(bebob);
> 673 err = -ETIMEDOUT;
> 674 }
> 675 }
>
> I think it better to apply your solution too in the above to keep code consistency.
How do you think about to adjust this function implementation after the other two
update steps from the patch series would be integrated?
> For the other patches, I can find no merit to apply except for reduction
> of the number of characters included in the file.
Would you like to refer to any specific update suggestions for further clarification?
Regards,
Markus
More information about the Alsa-devel
mailing list