[alsa-devel] [PATCH 02/14] soundwire: Add SoundWire bus type

Vinod Koul vinod.koul at intel.com
Mon Oct 30 14:11:04 CET 2017


On Fri, Oct 27, 2017 at 10:57:39AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 26, 2017 at 02:03:42PM +0530, Vinod Koul wrote:
> > On Fri, Oct 20, 2017 at 09:31:34PM +0530, Vinod Koul wrote:
> > > On Fri, Oct 20, 2017 at 12:45:28PM +0200, Greg Kroah-Hartman wrote:
> > > > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote:
> > 
> > > > > +struct bus_type sdw_bus_type = {
> > > > > +	.name = "soundwire",
> > > > > +	.match = sdw_bus_match,
> > > > > +	.uevent = sdw_uevent,
> > > > > +};
> > > > > +EXPORT_SYMBOL(sdw_bus_type);
> > > > 
> > > > No release callback?  Who frees the device?
> > 
> > Hmmm, bus_type doesn't seem to have a release callback. The sdw_device has
> > release and that is added in the next patch. So I am not changing anything
> > here. Let me know If I missed anything...
> 
> Ok, as long as you really have a release callback for when the device
> goes away, and you have tested device removal...

Yup both checks done, thanks for confirming...

-- 
~Vinod


More information about the Alsa-devel mailing list