[alsa-devel] [asoc:topic/intel 38/38] sound/soc/intel/common/sst-firmware.c:1278:20: error: expected declaration specifiers or '...' before string constant

[Takashi Iwai]

On Sun, 22 Oct 2017 15:00:38 +0200,
Pierre-Louis Bossart wrote:
> 
> On 10/22/17 3:25 PM, Pierre-Louis Bossart wrote:
> > Not sure what happened here, the code was posted on an internal
> > mailing list which is supposed to be checked by the 0-day
> > infrastructure precisely to avoid this sort of issues before going
> > upstream...
> >
> > Anyways, there is obviously a missing dependency on X86, this code
> > can't possibly work on extensa or s390.
> 
> I am really confused here, errors already happen with 4.13 (before my
> patches) with the two suggested configs, so it's either that 01-day
> added a new set of tests for extensa and s390 or didn't run tests
> correctly before?

I guess it happens because now you changed a few Kconfig items to be
user-selectable by adding the prompt.  Formerly, they were only
selected by the top-level drivers, and these top-level drivers have
the proper dependency on x86.  But the lower layers don't have the
dependency, and now you allow to select them freely, hence such a
thing may happen.


Takashi


> 
> >
> >
> > On 10/21/17 4:38 PM, kbuild test robot wrote:
> >> tree:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> >> topic/intel
> >> head:   f6a118a800e35af2c63f90cbcc23093f4b53b3a2
> >> commit: f6a118a800e35af2c63f90cbcc23093f4b53b3a2 [38/38] ASoC:
> >> Intel: clarify Kconfig dependencies
> >> config: xtensa-allyesconfig (attached as .config)
> >> compiler: xtensa-linux-gcc (GCC) 4.9.0
> >> reproduce:
> >>          wget
> >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> >> -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          git checkout f6a118a800e35af2c63f90cbcc23093f4b53b3a2
> >>          # save the attached .config to linux build tree
> >>          make.cross ARCH=xtensa
> >>
> >> All errors (new ones prefixed by >>):
> >>
> >>>> sound/soc/intel/common/sst-firmware.c:1278:20: error: expected
> >>>> declaration specifiers or '...' before string constant
> >>      MODULE_DESCRIPTION("Intel SST Firmware Loader");
> >>                         ^
> >>     sound/soc/intel/common/sst-firmware.c:1279:16: error: expected
> >> declaration specifiers or '...' before string constant
> >>      MODULE_LICENSE("GPL v2");
> >>                     ^
> >> -- 
> >>     sound/soc/intel/haswell/sst-haswell-pcm.c: In function
> >> 'create_adsp_page_table':
> >>>> sound/soc/intel/haswell/sst-haswell-pcm.c:446:2: error: implicit
> >>>> declaration of function 'snd_sgbuf_aligned_pages'
> >>>> [-Werror=implicit-function-declaration]
> >>       pages = snd_sgbuf_aligned_pages(size);
> >>       ^
> >>     cc1: some warnings being treated as errors
> >>
> >> vim +1278 sound/soc/intel/common/sst-firmware.c
> >>
> >> a395bdd6 Takashi Iwai 2016-07-11  1277
> >> a395bdd6 Takashi Iwai 2016-07-11 @1278  MODULE_DESCRIPTION("Intel
> >> SST Firmware Loader");
> >>
> >> :::::: The code at line 1278 was first introduced by commit
> >> :::::: a395bdd6b24b692adbce0df6510ec9f2af57573e ASoC: intel: Fix
> >> sst-dsp dependency on dw stuff
> >>
> >> :::::: TO: Takashi Iwai <tiwai at suse.de>
> >> :::::: CC: Mark Brown <broonie at kernel.org>
> >>
> >> ---
> >> 0-DAY kernel test infrastructure                Open Source
> >> Technology Center
> >> https://lists.01.org/pipermail/kbuild-all                   Intel
> >> Corporation
> >>
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel at alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel