[alsa-devel] [PATCH v3] ASoC: dapm: Avoid creating kcontrol for params

Charles Keepax ckeepax at opensource.cirrus.com
Mon Oct 9 10:34:56 CEST 2017


On Sun, Oct 08, 2017 at 11:29:45PM -0700, anish kumar wrote:
> On Fri, Sep 29, 2017 at 2:09 AM, Charles Keepax
> <ckeepax at opensource.cirrus.com> wrote:
> > On Thu, Sep 28, 2017 at 09:52:39PM -0700, yesanishhere at gmail.com wrote:
> >> From: anish kumar <yesanishhere at gmail.com>
> >>
> >> Currently in codec to codec dai link if there are multiple
> >> params defined then dapm can use created kcontrol to
> >> decide which param to apply at runtime.
> >>
> >> However, in case there is only single param configuration
> >> then there is no point in creating the kcontrol and also there
> >> is no point in allocating memory for kcontrol.
> >>
> >> In the snd_soc_dapm_new_pcm function, there is memory
> >> allocation happening for kcontrol which is later used
> >> or not used based on num_param. It is better to not
> >> allocate memory when there is only a single configuration.
> >> This change is to remedy that anomaly.
> >>
> >> Signed-off-by: anish kumar <yesanishhere at gmail.com>
> >> ---
> >
> > Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>
> > Tested-by: Charles Keepax <ckeepax at opensource.cirrus.com>
> 
> Charles, do you know if there is anything pending for this series
> to be picked up for merge in mark's tree?
> >

Its been picked up that's what that email from Mark is letting
you know. However, you do need to do an incremental patch on top
of this one for the issues the Intel build bot spotted with the
patch.

Thanks,
Charles


More information about the Alsa-devel mailing list