[alsa-devel] [PATCH 1/2] ASoC: img-i2s-in: Add suspend / resume handling

[Mark Brown]

On Thu, Oct 05, 2017 at 02:27:49PM +0100, Ed Blake wrote:
> On 04/10/17 11:37, Mark Brown wrote:

> > Why use the ASoC specific power management callbacks and not the system
> > ones?  It does also look a bit like there's a case for converting the
> > driver to regmap and using the regmap cache code.

> Looking at other drivers, most seemed to use the ASoC specific
> callbacks.  Are the system ones preferred?  If so I'll change it for v2.

Yes, look at newer drivers more here.  Unless you've a need to do some
ASoC specific stuff but that's not the case for this.

> > It does also look a bit like there's a case for converting the
> > driver to regmap and using the regmap cache code.

> Is it ok to do this in a future patch?

Well, the comment was there because you were open coding the regmap
cache sync code but it's not the end of the world to do it later.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20171005/441351d2/attachment.sig>