[alsa-devel] [PATCH 2/2] ASoC: soc-core: add snd_soc_add_component()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Oct 2 07:05:09 CEST 2017


Hi Mark

I will post v2 patch which includes this "remove unneeded message" patch set.

> >> >> > +       component = kzalloc(sizeof(*component), GFP_KERNEL);
> >> >> > +       if (!component) {
> >> >> > +               dev_err(dev, "ASoC: Failed to allocate memory\n");
> >> >> > +               return -ENOMEM;
> >> >>
> >> >> No need to print an error message if kzalloc fails. The core will print it.
> >> >
> >> > Thanks. Yes I had noticed this warning from checkpatch.
> >> > The main purpose of this patch is separate "register" function into
> >> > "register" and "add".
> >> > Thus, I keeped existing all code.
> >> > I think "remove unneeded message" should be increment patch,
> >> > but can you agree ?
> >>
> >> Makes sense. It's better to be sent as a separate patch.
> >
> > Thanks.
> > If you have no objection, I will post it if this patch was accepted.
> > Or do you do this ?
> 
> Lets have this patch reviewed & pushed and then will see. It's
> not that important.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


More information about the Alsa-devel mailing list