[alsa-devel] [PATCH 0/6] ALSA: pcm: check parameter on snd_pcm_running()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Nov 28 07:53:39 CET 2017


Hi Takashi

> > I wonder are these patches acceptable ? or not ?
> > If acceptable, should I resend ?
> 
> Since the use-case to pass NULL is limited, I'd rather avoid the
> change.  If there were more than handful users, maybe I would rethink,
> but currently not convincing enough.
> 
> And, the NULL check is needed only when the caller is outside the
> stream lock.  Such a situation already smells like a buggy code.
> We don't need to make it easier :)

OK, I see
Let's remove it so far
Thanks

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list