[alsa-devel] [PATCH 2/6] ALSA: pdaudiocf: remove unneeded check for snd_pcm_running()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Nov 9 03:12:13 CET 2017


From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

snd_pcm_running() itself is checking parameter now.
Let's remove duplicate check

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---
 sound/pcmcia/pdaudiocf/pdaudiocf_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf_irq.c b/sound/pcmcia/pdaudiocf/pdaudiocf_irq.c
index ecf0fbd..9377505 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf_irq.c
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf_irq.c
@@ -265,7 +265,7 @@ irqreturn_t pdacf_threaded_irq(int irq, void *dev)
 	if ((chip->chip_status & (PDAUDIOCF_STAT_IS_STALE|PDAUDIOCF_STAT_IS_CONFIGURED)) != PDAUDIOCF_STAT_IS_CONFIGURED)
 		return IRQ_HANDLED;
 	
-	if (chip->pcm_substream == NULL || chip->pcm_substream->runtime == NULL || !snd_pcm_running(chip->pcm_substream))
+	if (!snd_pcm_running(chip->pcm_substream))
 		return IRQ_HANDLED;
 
 	rdp = inw(chip->port + PDAUDIOCF_REG_RDP);
-- 
1.9.1



More information about the Alsa-devel mailing list