[alsa-devel] [PATCH 08/14] soundwire: Add Slave status handling helpers

[Vinod Koul]

On Wed, Nov 01, 2017 at 04:10:08PM -0500, Pierre-Louis Bossart wrote:
> On 11/1/17 4:08 AM, Vinod Koul wrote:
> >On Wed, Nov 01, 2017 at 02:49:15AM +0530, Pierre-Louis Bossart wrote:
> >>>
> >>>BUT given that we have seen stuff i am inclined to add a counter, we cant
> >>>have more than 11 device so that's a sane value to use :)
> >>
> >>Yep. Keep in mind however that there could be theoretical corner cases: if a
> >>device is enumerated, loses sync and becomes attached again while you deal
> >>with others, you'd have more than 11 iterations.
> >
> >Not really as that would be another interrupt and another status report.
> 
> You are in a loop where you keep reading the devId registers, and that
> really has nothing to do with interrupts or status report. The point was
> that the number of times you read may be higher that the number of devices
> with a device being handled several times.
> As mentioned above you need to limit this loop to a sane value.

Oh yes, I was thinking from status point of view which triggers this but yes
we keep reading so your point is valid. Lets add 2x buffer for that.

-- 
~Vinod