[alsa-devel] [PATCH v2 1/3] ALSA: usb-audio: fix Amanero Combo384 quirk on big-endian hosts

[Jussi Laako]

On 12.05.2017 15:34, Johan Hovold wrote:
> Add missing endianness conversion when using the USB device-descriptor
> bcdDevice field when applying the Amanero Combo384 (endianness!) quirk.
> 
> Fixes: 3eff682d765b ("ALSA: usb-audio: Support both DSD LE/BE Amanero firmware versions")
> Cc: Jussi Laako <jussi at sonarnerd.net>
> Signed-off-by: Johan Hovold <johan at kernel.org>
> ---
>   sound/usb/quirks.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 01eff6ce6401..d7b0b0a3a2db 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1364,7 +1364,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
>   	/* Amanero Combo384 USB interface with native DSD support */
>   	case USB_ID(0x16d0, 0x071a):
>   		if (fp->altsetting == 2) {
> -			switch (chip->dev->descriptor.bcdDevice) {
> +			switch (le16_to_cpu(chip->dev->descriptor.bcdDevice)) {
>   			case 0x199:
>   				return SNDRV_PCM_FMTBIT_DSD_U32_LE;
>   			case 0x19b:
> 


Sorry for the delay... Looks good to me, tested to work OK.


	- Jussi Laako