[alsa-devel] [PATCH 2/2] ALSA: pcm: add arrangement for applying appl_ptr

[Takashi Iwai]

On Fri, 26 May 2017 08:42:41 +0200,
Takashi Sakamoto wrote:
> 
> On May 26 2017 15:40, Takashi Iwai wrote:
> > On Fri, 26 May 2017 02:30:47 +0200,
> > Takashi Sakamoto wrote:
> >>
> >> In callgraphs from below kernel APIs, position of application pointer on
> >> PCM buffer is changes, according to given parameters.
> >>
> >>   - snd_pcm_lib_read()
> >>   - snd_pcm_lib_readv()
> >>   - snd_pcm_lib_write()
> >>   - snd_pcm_lib_writev()
> >>
> >> This operation corresponds to application of new position to runtime of
> >> PCM substream and callback of driver's implementation for
> >> 'struct snd_pcm_ops.ack'.
> >>
> >> In a former commit, a new local function is added, 'apply_appl_ptr'. The
> >> above code block can be replaced with this function.
> >>
> >> This commit replaces the code block with call of the function. The function
> >> is renamed to be shared by several objects.
> >>
> >> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> >
> > Queued now, but will be likely declined later due to the rewrites of
> > the code.
> 
> Due to your recent work under reviewing?

Yes, the code might be changed heavily.
Don't touch a too hot spot if it were only a cleanup.


thanks,

Takashi